[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 32/35] acpi: pc/q35: remove not needed 'if' condition on pci
From: |
Ani Sinha |
Subject: |
Re: [PATCH 32/35] acpi: pc/q35: remove not needed 'if' condition on pci bus |
Date: |
Wed, 18 May 2022 14:13:21 +0530 |
On Mon, May 16, 2022 at 8:56 PM Igor Mammedov <imammedo@redhat.com> wrote:
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <ani@anisinha.ca>
> ---
> hw/i386/acpi-build.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 85a7313cad..414b9240b2 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1748,16 +1748,10 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
>
> sb_scope = aml_scope("\\_SB");
> {
> - Object *pci_host;
> - PCIBus *bus = NULL;
> -
> - pci_host = acpi_get_i386_pci_host();
> + Object *pci_host = acpi_get_i386_pci_host();
>
> if (pci_host) {
> - bus = PCI_HOST_BRIDGE(pci_host)->bus;
> - }
> -
> - if (bus) {
> + PCIBus *bus = PCI_HOST_BRIDGE(pci_host)->bus;
> Aml *scope = aml_scope("PCI0");
> /* Scan all PCI buses. Generate tables to support hotplug. */
> build_append_pci_bus_devices(scope, bus, pm->pcihp_bridge_en);
> --
> 2.31.1
>
- Re: [PATCH 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, (continued)
- [PATCH 25/35] tests: acpi: update expected blobs, Igor Mammedov, 2022/05/16
- [PATCH 31/35] acpi: pc/q35: tpm-tis: fix TPM device scope, Igor Mammedov, 2022/05/16
- [PATCH 29/35] tests: acpi: update expected DSDT.pvpanic-isa blob, Igor Mammedov, 2022/05/16
- [PATCH 30/35] tests: acpi: white-list DSDT.tis.tpm2/DSDT.tis.tpm12 expected blobs, Igor Mammedov, 2022/05/16
- [PATCH 32/35] acpi: pc/q35: remove not needed 'if' condition on pci bus, Igor Mammedov, 2022/05/16
- Re: [PATCH 32/35] acpi: pc/q35: remove not needed 'if' condition on pci bus,
Ani Sinha <=
- [PATCH 35/35] x86: acpi-build: do not include hw/isa/isa.h directly, Igor Mammedov, 2022/05/16
- [PATCH 34/35] tests: acpi: update expected DSDT.tis.tpm2/DSDT.tis.tpm12 blobs, Igor Mammedov, 2022/05/16
- [PATCH 33/35] acpi: tpm-tis: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, Igor Mammedov, 2022/05/16
- Re: [PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation, Michael S. Tsirkin, 2022/05/16
- Re: [PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation, Gerd Hoffmann, 2022/05/17