[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml
From: |
Igor Mammedov |
Subject: |
Re: [PATCH 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML |
Date: |
Thu, 26 May 2022 15:57:55 +0200 |
On Wed, 18 May 2022 12:29:25 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, May 17, 2022 at 10:13:51AM +0200, Gerd Hoffmann wrote:
> > That problem isn't new and we already have a bunch of aml_* stubs
> > because of that. I expect it'll work just fine, at worst we'll
> > have to add a stub or two in case some calls are not covered yet.
>
> Right but adding these stubs is a bother, we keep missing some.
> If possible I'd like the solution to be cleaner than the status quo.
> Is adding a wrapper instead of setting a method directly such
> a big problem really?
>
here is stub based ACPI decoupling for isa devices we currently
have in the tree:
https://gitlab.com/imammedo/qemu/-/commits/decouple_build_aml_v1/
If it looks acceptable to you, I can prep/post it first and
then rebase this series on top to reduce unnecessary churning.
- [PATCH 22/35] tests: acpi: add and white-list DSDT.applesmc expected blob, (continued)
- [PATCH 22/35] tests: acpi: add and white-list DSDT.applesmc expected blob, Igor Mammedov, 2022/05/16
- [PATCH 21/35] tests: acpi: update expected blobs, Igor Mammedov, 2022/05/16
- [PATCH 24/35] acpi: applesmc: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, Igor Mammedov, 2022/05/16
- [PATCH 26/35] tests: acpi: white-lists expected DSDT.pvpanic-isa blob, Igor Mammedov, 2022/05/16
- [PATCH 27/35] tests: acpi: add pvpanic-isa: testcase, Igor Mammedov, 2022/05/16
- [PATCH 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, Igor Mammedov, 2022/05/16
- Re: [PATCH 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, Igor Mammedov, 2022/05/17
- Re: [PATCH 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, Igor Mammedov, 2022/05/19
[PATCH 25/35] tests: acpi: update expected blobs, Igor Mammedov, 2022/05/16
[PATCH 31/35] acpi: pc/q35: tpm-tis: fix TPM device scope, Igor Mammedov, 2022/05/16
[PATCH 29/35] tests: acpi: update expected DSDT.pvpanic-isa blob, Igor Mammedov, 2022/05/16
[PATCH 30/35] tests: acpi: white-list DSDT.tis.tpm2/DSDT.tis.tpm12 expected blobs, Igor Mammedov, 2022/05/16
[PATCH 32/35] acpi: pc/q35: remove not needed 'if' condition on pci bus, Igor Mammedov, 2022/05/16