[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 092/117] target/arm: Move null function and sve check into do_redu
From: |
Peter Maydell |
Subject: |
[PULL 092/117] target/arm: Move null function and sve check into do_reduce |
Date: |
Mon, 30 May 2022 17:06:43 +0100 |
From: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220527181907.189259-90-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/translate-sve.c | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 11e4b4e1e4a..0d71072f837 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -3572,15 +3572,24 @@ TRANS_FEAT(FMUL_zzx, aa64_sve, gen_gvec_fpst_zzz,
typedef void gen_helper_fp_reduce(TCGv_i64, TCGv_ptr, TCGv_ptr,
TCGv_ptr, TCGv_i32);
-static void do_reduce(DisasContext *s, arg_rpr_esz *a,
+static bool do_reduce(DisasContext *s, arg_rpr_esz *a,
gen_helper_fp_reduce *fn)
{
- unsigned vsz = vec_full_reg_size(s);
- unsigned p2vsz = pow2ceil(vsz);
- TCGv_i32 t_desc = tcg_constant_i32(simd_desc(vsz, vsz, p2vsz));
+ unsigned vsz, p2vsz;
+ TCGv_i32 t_desc;
TCGv_ptr t_zn, t_pg, status;
TCGv_i64 temp;
+ if (fn == NULL) {
+ return false;
+ }
+ if (!sve_access_check(s)) {
+ return true;
+ }
+
+ vsz = vec_full_reg_size(s);
+ p2vsz = pow2ceil(vsz);
+ t_desc = tcg_constant_i32(simd_desc(vsz, vsz, p2vsz));
temp = tcg_temp_new_i64();
t_zn = tcg_temp_new_ptr();
t_pg = tcg_temp_new_ptr();
@@ -3596,23 +3605,18 @@ static void do_reduce(DisasContext *s, arg_rpr_esz *a,
write_fp_dreg(s, a->rd, temp);
tcg_temp_free_i64(temp);
+ return true;
}
#define DO_VPZ(NAME, name) \
static bool trans_##NAME(DisasContext *s, arg_rpr_esz *a) \
{ \
- static gen_helper_fp_reduce * const fns[3] = { \
- gen_helper_sve_##name##_h, \
+ static gen_helper_fp_reduce * const fns[4] = { \
+ NULL, gen_helper_sve_##name##_h, \
gen_helper_sve_##name##_s, \
gen_helper_sve_##name##_d, \
}; \
- if (a->esz == 0) { \
- return false; \
- } \
- if (sve_access_check(s)) { \
- do_reduce(s, a, fns[a->esz - 1]); \
- } \
- return true; \
+ return do_reduce(s, a, fns[a->esz]); \
}
DO_VPZ(FADDV, faddv)
--
2.25.1
- [PULL 061/117] target/arm: Use gen_gvec_ool_arg_zzz for do_zip, do_zip_q, (continued)
- [PULL 061/117] target/arm: Use gen_gvec_ool_arg_zzz for do_zip, do_zip_q, Peter Maydell, 2022/05/30
- [PULL 070/117] target/arm: Use TRANS_FEAT for do_sve2_ppzz_flags, Peter Maydell, 2022/05/30
- [PULL 073/117] target/arm: Use TRANS_FEAT for MUL_zzi, Peter Maydell, 2022/05/30
- [PULL 074/117] target/arm: Reject dup_i w/ shifted byte early, Peter Maydell, 2022/05/30
- [PULL 094/117] target/arm: Use TRANS_FEAT for FRECPE, FRSQRTE, Peter Maydell, 2022/05/30
- [PULL 095/117] target/arm: Expand frint_fns for MO_8, Peter Maydell, 2022/05/30
- [PULL 096/117] target/arm: Rename do_zpz_ptr to gen_gvec_ool_fpst_arg_zpz, Peter Maydell, 2022/05/30
- [PULL 082/117] target/arm: Move sve check into gen_gvec_fn_ppp, Peter Maydell, 2022/05/30
- [PULL 084/117] target/arm: Use TRANS_FEAT for SEL_zpzz, Peter Maydell, 2022/05/30
- [PULL 086/117] target/arm: Use TRANS_FEAT for FMLA, Peter Maydell, 2022/05/30
- [PULL 092/117] target/arm: Move null function and sve check into do_reduce,
Peter Maydell <=
- [PULL 064/117] target/arm: Use TRANS_FEAT for do_clast_fp, Peter Maydell, 2022/05/30
- [PULL 075/117] target/arm: Reject add/sub w/ shifted byte early, Peter Maydell, 2022/05/30
- [PULL 080/117] target/arm: Introduce gen_gvec_{ptr,fpst}_zzzz, Peter Maydell, 2022/05/30
- [PULL 027/117] target/arm: Use TRANS_FEAT for gen_gvec_ool_arg_zpzi, Peter Maydell, 2022/05/30
- [PULL 079/117] target/arm: Use TRANS_FEAT for do_zzi_ool, Peter Maydell, 2022/05/30
- [PULL 087/117] target/arm: Use TRANS_FEAT for BFMLA, Peter Maydell, 2022/05/30
- [PULL 051/117] target/arm: Move sve check into do_index, Peter Maydell, 2022/05/30
- [PULL 066/117] target/arm: Use TRANS_FEAT for do_last_fp, Peter Maydell, 2022/05/30
- [PULL 072/117] target/arm: Use TRANS_FEAT for do_brk2, do_brk3, Peter Maydell, 2022/05/30
- [PULL 071/117] target/arm: Use TRANS_FEAT for do_ppzi_flags, Peter Maydell, 2022/05/30