[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty
From: |
Alberto Faria |
Subject: |
[PATCH v5 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty() |
Date: |
Thu, 9 Jun 2022 16:27:44 +0100 |
Use bdrv_pwrite_sync() instead of calling bdrv_pwrite() and bdrv_flush()
separately.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/qcow2.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index f2fb54c51f..90a2dd406b 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -516,12 +516,9 @@ int qcow2_mark_dirty(BlockDriverState *bs)
}
val = cpu_to_be64(s->incompatible_features | QCOW2_INCOMPAT_DIRTY);
- ret = bdrv_pwrite(bs->file, offsetof(QCowHeader, incompatible_features),
- sizeof(val), &val, 0);
- if (ret < 0) {
- return ret;
- }
- ret = bdrv_flush(bs->file->bs);
+ ret = bdrv_pwrite_sync(bs->file,
+ offsetof(QCowHeader, incompatible_features),
+ sizeof(val), &val, 0);
if (ret < 0) {
return ret;
}
--
2.35.3
- [PATCH v5 00/10] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper, Alberto Faria, 2022/06/09
- [PATCH v5 01/10] block: Add a 'flags' param to bdrv_{pread, pwrite, pwrite_sync}(), Alberto Faria, 2022/06/09
- [PATCH v5 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order, Alberto Faria, 2022/06/09
- [PATCH v5 04/10] crypto: Make block callbacks return 0 on success, Alberto Faria, 2022/06/09
- [PATCH v5 05/10] block: Make bdrv_co_pwrite() take a const buffer, Alberto Faria, 2022/06/09
- [PATCH v5 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t, Alberto Faria, 2022/06/09
- [PATCH v5 08/10] block: Add bdrv_co_pwrite_sync(), Alberto Faria, 2022/06/09
- [PATCH v5 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty(),
Alberto Faria <=
- [PATCH v5 03/10] block: Make bdrv_{pread, pwrite}() return 0 on success, Alberto Faria, 2022/06/09
- [PATCH v5 07/10] block: Implement bdrv_{pread, pwrite, pwrite_zeroes}() using generated_co_wrapper, Alberto Faria, 2022/06/09
- [PATCH v5 09/10] block: Use bdrv_co_pwrite_sync() when caller is coroutine_fn, Alberto Faria, 2022/06/09
- Re: [PATCH v5 00/10] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper, Alberto Faria, 2022/06/23