[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] gdbstub: don't crash if no gdb attached and gdb syscall
From: |
Alex Bennée |
Subject: |
Re: [PATCH 0/2] gdbstub: don't crash if no gdb attached and gdb syscall attempted |
Date: |
Fri, 10 Jun 2022 15:40:45 +0100 |
User-agent: |
mu4e 1.7.26; emacs 28.1.50 |
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 26 May 2022 at 20:00, Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> This patchset fixes a couple of bugs reported by
>> Liviu Ionescu related to semihosting syscall handling.
>>
>> Firstly, if the user sets up the gdbstub but doesn't connect a gdb
>> (ie passes '-s' but not '-S'), and we try to use gdb for semihosting
>> syscalls (either because the user explicitly set target=gdb or else
>> via autodetection) then we currently segfault. This patch adjusts
>> the behaviour so that "gdbstub initialized but no gdb attached to a
>> vCPU" is treated the same way we already treat "gdbstub not
>> initialized".
>>
>> Secondly, we weren't handling commandlines where
>> --semihosting-config appears multiple times: these ought to be
>> merged together but instead we were effectively ignoring
>> all but the last one.
>>
>> thanks
>> -- PMM
>>
>> Peter Maydell (2):
>> gdbstub: Don't use GDB syscalls if no GDB is attached
>> semihosting/config: Merge --semihosting-config option groups
>
> I'll take these via target-arm.next.
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée