|
| From: | Juan Quintela |
| Subject: | Re: [PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works |
| Date: | Mon, 20 Jun 2022 10:48:13 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Leonardo Bras <leobras@redhat.com> wrote:
> Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial
> part of the flushing mechanism got missing: incrementing zero_copy_queued.
>
> Without that, the flushing interface becomes a no-op, and there is no
> guarantee the buffer is really sent.
>
> This can go as bad as causing a corruption in RAM during migration.
>
> Fixes: 2bc58ffc2926 ("QIOChannelSocket: Implement io_writev zero copy
> flag & io_flush for CONFIG_LINUX")
> Reported-by: 徐闯 <xuchuangxclwt@bytedance.com>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
| [Prev in Thread] | Current Thread | [Next in Thread] |