qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/12] pc-bios/s390-ccw/virtio: Read device config after feat


From: Cornelia Huck
Subject: Re: [PATCH 07/12] pc-bios/s390-ccw/virtio: Read device config after feature negotiation
Date: Tue, 28 Jun 2022 15:25:30 +0200
User-agent: Notmuch/0.36 (https://notmuchmail.org)

On Tue, Jun 28 2022, Thomas Huth <thuth@redhat.com> wrote:

> Feature negotiation should be done first, since some fields in the
> config area can depend on the negotiated features and thus should
> rather be read afterwards.
>
> While we're at it, also adjust the error message here a little bit
> (the code is nowadays used for non-block virtio devices, too).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  pc-bios/s390-ccw/virtio.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]