qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates


From: Klaus Jensen
Subject: Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates
Date: Thu, 14 Jul 2022 07:35:15 +0200

On Jul 12 14:23, Klaus Jensen wrote:
> On Jul  9 11:06, Jinhao Fan wrote:
> > at 10:24 PM, Jinhao Fan <fanjinhao21s@ict.ac.cn> wrote:
> > 
> > > @@ -5793,6 +5891,7 @@ static uint16_t nvme_dbbuf_config(NvmeCtrl *n, 
> > > const NvmeRequest *req)
> > >     uint64_t dbs_addr = le64_to_cpu(req->cmd.dptr.prp1);
> > >     uint64_t eis_addr = le64_to_cpu(req->cmd.dptr.prp2);
> > >     int i;
> > > +    int ret;
> > > 
> > 
> > I just noticed this ret is unused. Could you help remove this line when
> > applying the patch?
> 
> Yes, I noticed it and hot-fixed it ;)

Jinhao,

Applied to nvme-next!

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]