[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/7] libvduse: Pass positive value to strerror()
From: |
Kevin Wolf |
Subject: |
[PULL 4/7] libvduse: Pass positive value to strerror() |
Date: |
Tue, 2 Aug 2022 15:37:54 +0200 |
From: Xie Yongji <xieyongji@bytedance.com>
The value passed to strerror() should be positive.
So let's fix it.
Fixes: Coverity CID 1490226, 1490223
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220706095624.328-4-xieyongji@bytedance.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
subprojects/libvduse/libvduse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/subprojects/libvduse/libvduse.c b/subprojects/libvduse/libvduse.c
index 1e36227388..1a5981445c 100644
--- a/subprojects/libvduse/libvduse.c
+++ b/subprojects/libvduse/libvduse.c
@@ -1257,7 +1257,7 @@ VduseDev *vduse_dev_create_by_name(const char *name,
uint16_t num_queues,
ret = vduse_dev_init(dev, name, num_queues, ops, priv);
if (ret < 0) {
fprintf(stderr, "Failed to init vduse device %s: %s\n",
- name, strerror(ret));
+ name, strerror(-ret));
free(dev);
return NULL;
}
@@ -1331,7 +1331,7 @@ VduseDev *vduse_dev_create(const char *name, uint32_t
device_id,
ret = vduse_dev_init(dev, name, num_queues, ops, priv);
if (ret < 0) {
fprintf(stderr, "Failed to init vduse device %s: %s\n",
- name, strerror(ret));
+ name, strerror(-ret));
goto err;
}
--
2.35.3
- [PULL 0/7] Block layer patches, Kevin Wolf, 2022/08/02
- [PULL 4/7] libvduse: Pass positive value to strerror(),
Kevin Wolf <=
- [PULL 2/7] libvduse: Fix the incorrect function name, Kevin Wolf, 2022/08/02
- [PULL 1/7] block/io_uring: add missing include file, Kevin Wolf, 2022/08/02
- [PULL 3/7] libvduse: Replace strcpy() with strncpy(), Kevin Wolf, 2022/08/02
- [PULL 6/7] qemu-iotests: Discard stderr when probing devices, Kevin Wolf, 2022/08/02
- [PULL 7/7] main loop: add missing documentation links to GS/IO macros, Kevin Wolf, 2022/08/02
- [PULL 5/7] hw/block/hd-geometry: Do not override specified bios-chs-trans, Kevin Wolf, 2022/08/02
- Re: [PULL 0/7] Block layer patches, Richard Henderson, 2022/08/02