[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/7] hw/loongarch: remove acpi-build.c unused variable 'aml_len'
From: |
Richard Henderson |
Subject: |
[PULL 2/7] hw/loongarch: remove acpi-build.c unused variable 'aml_len' |
Date: |
Fri, 5 Aug 2022 12:55:10 -0700 |
From: Song Gao <gaosong@loongson.cn>
Fix a compiler warning on openbsd:
../src/hw/loongarch/acpi-build.c:416:12: warning: variable 'aml_len'
set but not used [-Wunused-but-set-variable]
size_t aml_len = 0;
^
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Song Gao <gaosong@loongson.cn>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220721040046.3985609-1-gaosong@loongson.cn>
[rth: Removing aml_len in turn makes fadt set but not used.]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/loongarch/acpi-build.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c
index 4b4529a3fb..d0f01a6485 100644
--- a/hw/loongarch/acpi-build.c
+++ b/hw/loongarch/acpi-build.c
@@ -411,9 +411,8 @@ static void acpi_build(AcpiBuildTables *tables,
MachineState *machine)
LoongArchMachineState *lams = LOONGARCH_MACHINE(machine);
GArray *table_offsets;
AcpiFadtData fadt_data;
- unsigned facs, rsdt, fadt, dsdt;
+ unsigned facs, rsdt, dsdt;
uint8_t *u;
- size_t aml_len = 0;
GArray *tables_blob = tables->table_data;
init_common_fadt_data(&fadt_data);
@@ -437,21 +436,13 @@ static void acpi_build(AcpiBuildTables *tables,
MachineState *machine)
dsdt = tables_blob->len;
build_dsdt(tables_blob, tables->linker, machine);
- /*
- * Count the size of the DSDT, we will need it for
- * legacy sizing of ACPI tables.
- */
- aml_len += tables_blob->len - dsdt;
-
/* ACPI tables pointed to by RSDT */
- fadt = tables_blob->len;
acpi_add_table(table_offsets, tables_blob);
fadt_data.facs_tbl_offset = &facs;
fadt_data.dsdt_tbl_offset = &dsdt;
fadt_data.xdsdt_tbl_offset = &dsdt;
build_fadt(tables_blob, tables->linker, &fadt_data,
lams->oem_id, lams->oem_table_id);
- aml_len += tables_blob->len - fadt;
acpi_add_table(table_offsets, tables_blob);
build_madt(tables_blob, tables->linker, lams);
--
2.34.1
- [PULL 0/7] loongarch patch queue, Richard Henderson, 2022/08/05
- [PULL 1/7] target/loongarch: Fix macros SET_FPU_* in cpu.h, Richard Henderson, 2022/08/05
- [PULL 2/7] hw/loongarch: remove acpi-build.c unused variable 'aml_len',
Richard Henderson <=
- [PULL 3/7] target/loongarch: Fix GDB get the wrong pc, Richard Henderson, 2022/08/05
- [PULL 5/7] target/loongarch: update loongarch-base64.xml, Richard Henderson, 2022/08/05
- [PULL 4/7] target/loongarch: add gdb_arch_name(), Richard Henderson, 2022/08/05
- [PULL 6/7] target/loongarch: Update loongarch-fpu.xml, Richard Henderson, 2022/08/05
- [PULL 7/7] target/loongarch: Update gdb_set_fpu() and gdb_get_fpu(), Richard Henderson, 2022/08/05
- Re: [PULL 0/7] loongarch patch queue, Richard Henderson, 2022/08/05