Re: [PATCH for-7.2 v2 09/20] hw/ppc: set machine->fdt in pnv_reset()

[Cédric Le Goater]

On 8/8/22 08:47, Cédric Le Goater wrote:
> On 8/5/22 11:39, Daniel Henrique Barboza wrote:
> > This will enable support for 'dumpdtb' and 'info fdt' HMP commands for
> > all powernv machines.
>
> I might have missed some emails but dumpdtb is already suppported :
> commit 8d4092614161 ("ppc/pnv: activate the "dumpdtb" option on the
> powernv machine")

ok. found the patchset "QMP/HMP: add 'dumpdtb' and 'info fdt' commands"

'info fdt' would have been of great help when we were developing the
PowerNV machine. Initially, I was even using pmemsave to extract the
FDT blob ... So this is a great idea ! (which needs a g_free() )

Do we have something similar to dump ACPI tables, btw ?

Thanks,
 
C.


> > Cc: Cédric Le Goater <clg@kaod.org>
> > Cc: Frederic Barrat <fbarrat@linux.ibm.com>
> > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> > ---
> >   hw/ppc/pnv.c | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> > index d3f77c8367..f5162f8b7b 100644
> > --- a/hw/ppc/pnv.c
> > +++ b/hw/ppc/pnv.c
> > @@ -608,7 +608,11 @@ static void pnv_reset(MachineState *machine)
> >       qemu_fdt_dumpdtb(fdt, fdt_totalsize(fdt));
> >       cpu_physical_memory_write(PNV_FDT_ADDR, fdt, fdt_totalsize(fdt));
> > -    g_free(fdt);
> > +    /*
> > +     * Update the machine->fdt pointer to enable support for
> > +     * 'dumpdtb' and 'info fdt' commands.
> > +     */
> > +    machine->fdt = fdt;
> >   }
> >   static ISABus *pnv_chip_power8_isa_create(PnvChip *chip, Error **errp)