[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] virtio-blk and scsi: replace dataplane_{start/stopping/s
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 0/2] virtio-blk and scsi: replace dataplane_{start/stopping/started} |
Date: |
Mon, 8 Aug 2022 12:29:26 -0400 |
On Mon, Aug 08, 2022 at 05:41:45AM -0400, Emanuele Giuseppe Esposito wrote:
> The way the dataplane stages at startup and stop are monitored is unnecessary
> complicated. In virtio-scsi we have dataplane_started, dataplane_starting and
> dataplane_stopping in VirtIOSCSI.
> In virtio-blk we have dataplene_started in VirtIOBlock, and starting and
> stopping
> in VirtIOBlockDataPlane.
>
> Just replace all these flags with an atomic enum.
>
> Based-on: 20220803162824.948023-1-stefanha@redhat.com
Hi Emanuele,
I posted a v2 of my virtio-scsi dataplane startup race condition fix
that's related to this patch. This time it's based on how virtio-blk
does it.
We can merge both our patch series or just one of them in order to fix
the race condition.
Stefan
>
> Emanuele Giuseppe Esposito (2):
> virtio-scsi: replace VirtIOBlock dataplane_{start/starting/stopped}
> with enum
> virtio-blk: replace dataplane_start/stopping/started with enum
>
> hw/block/dataplane/virtio-blk.c | 24 +++++++++---------------
> hw/block/virtio-blk.c | 9 +++++----
> hw/scsi/virtio-scsi-dataplane.c | 21 +++++++++------------
> hw/scsi/virtio-scsi.c | 10 ++++++----
> include/hw/virtio/virtio-blk.h | 2 +-
> include/hw/virtio/virtio-scsi.h | 5 ++---
> include/hw/virtio/virtio.h | 7 +++++++
> 7 files changed, 39 insertions(+), 39 deletions(-)
>
> --
> 2.31.1
>
signature.asc
Description: PGP signature