qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 01/12] multifd: Create page_size fields into both MultiFD{


From: Juan Quintela
Subject: Re: [PATCH v7 01/12] multifd: Create page_size fields into both MultiFD{Recv,Send}Params
Date: Sat, 13 Aug 2022 17:41:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)

Leonardo Brás <leobras@redhat.com> wrote:
> Hello Juan,
>
> On Tue, 2022-08-02 at 08:38 +0200, Juan Quintela wrote:
>> We were calling qemu_target_page_size() left and right.
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> IMHO looks a good idea to bring that info inside the multifd parameters.

Thanks.

[...]

> IIUC this info should never change after assigned, and is the same on every
> multifd channel param. 

registered_yank?  Perhaps, I have to look.

packet_len, page_size, page_count and write_flags: They never really change.

But on the other hand, So we are "wasting" 16bytes per channel.

> I wonder if it would be interesting to have a common area for this kind of 
> info,
> which could be referenced by every multifd channel parameter.
> Or maybe too much trouble?

Will take a look on the future, the bigger problem that I can think of
is that we are already passing the MultiFD{Send,Recv}Params to each
function, so having them globaly will means to have global variable or
adding a pointer (8bytes) to each params, so not sure it is a good idea
with current amount of constants.

> Anyway, FWIW:
> Reviewed-by: Leonardo Bras <leobras@redhat.com>

thanks, Juan.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]