Re: [PATCH 08/17] target/i386: add 28-2f, 38-3f opcodes

[Richard Henderson]

On 8/24/22 10:32, Paolo Bonzini wrote:
> @@ -183,8 +202,7 @@ static void gen_XOR(DisasContext *s, CPUX86State *env, 
> X86DecodedInsn *decode)
>           decode->op[2].alu_op_type == X86_ALU_GPR &&
>           decode->op[1].n == decode->op[2].n) {
>           tcg_gen_movi_tl(s->T0, 0);
> -        gen_op_update1_cc(s);
> -        set_cc_op(s, CC_OP_LOGICB + decode->op[0].ot);
> +        set_cc_op(s, CC_OP_CLR);
>       } else {
>           gen_alu_op(s, OP_XORL, decode->op[0].ot);
>       }

Should be squashed with previous.


r~