Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 C

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 C

From:	Christoph Müllner
Subject:	Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs
Date:	Thu, 8 Sep 2022 10:23:27 +0200

On Thu, Sep 8, 2022 at 9:46 AM Richard Henderson <richard.henderson@linaro.org> wrote:

On 9/6/22 13:22, Christoph Muellner wrote:
> + DEFINE_CPU(TYPE_RISCV_CPU_THEAD_C906, rv64_thead_c906_cpu_init),
> + DEFINE_CPU(TYPE_RISCV_CPU_THEAD_C910, rv64_thead_c906_cpu_init),

Why model both if they're identical?

I figured that users might expect that (existence of "thead-c906" and "thead-c910").

And using "thead-c9xx" feels like it would be regretted in the future.

Should I drop "thead-c910"?

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 06/11] RISC-V: Adding T-Head multiply-accumulate instructions, (continued)
- [PATCH 06/11] RISC-V: Adding T-Head multiply-accumulate instructions, Christoph Muellner, 2022/09/06
- [PATCH 05/11] RISC-V: Adding T-Head CondMov instructions, Christoph Muellner, 2022/09/06
- [PATCH 07/11] RISC-V: Adding T-Head XMAE support, Christoph Muellner, 2022/09/06
- [PATCH 08/11] RISC-V: Adding T-Head MemPair extension, Christoph Muellner, 2022/09/06
- [PATCH 10/11] RISC-V: Adding T-Head FMemIdx extension, Christoph Muellner, 2022/09/06
  - Re: [PATCH 10/11] RISC-V: Adding T-Head FMemIdx extension, Richard Henderson, 2022/09/08
    - Re: [PATCH 10/11] RISC-V: Adding T-Head FMemIdx extension, Christoph Müllner, 2022/09/09
- [PATCH 09/11] RISC-V: Adding T-Head MemIdx extension, Christoph Muellner, 2022/09/06
- [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs, Christoph Muellner, 2022/09/06
  - Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs, Richard Henderson, 2022/09/08
    - Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs, Christoph Müllner <=
    - Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs, Richard Henderson, 2022/09/08
    - Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs, Christoph Müllner, 2022/09/08

Prev by Date: [PATCH v3] audio: add help option for -audio and -audiodev
Next by Date: Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one
Previous by thread: Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs
Next by thread: Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs
Index(es):
- Date
- Thread