Re: [PATCH v2 19/37] target/i386: reimplement 0x0f 0x60-0x6f, add AVX

[Richard Henderson]

On 9/20/22 17:24, Paolo Bonzini wrote:
> +static void gen_MOVD_to(DisasContext *s, CPUX86State *env, X86DecodedInsn 
> *decode)
> +{
> +    MemOp ot = decode->op[2].ot;
> +    int vec_len = vector_len(s, decode);
> +    int lo_ofs = vector_elem_offset(&decode->op[0], ot, 0);
> +
> +    tcg_gen_gvec_dup_imm(MO_64, decode->op[0].offset, vec_len, vec_len, 0);
> +
> +    switch (ot) {
> +    case MO_32:
> +#ifdef TARGET_X86_64
> +        tcg_gen_trunc_tl_i32(s->tmp3_i32, s->T1);
> +        tcg_gen_st_i32(s->tmp3_i32, cpu_env, lo_ofs);

As before, tcg_gen_st32_tl and no need for truncate.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~