|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 01/42] target/arm: Split s2walk_secure from ipa_secure in get_phys_addr |
Date: | Thu, 6 Oct 2022 11:20:40 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 10/6/22 08:22, Peter Maydell wrote:
Yeah, cleared-at-start is fine. But here we're also relying on the stage 2 call to get_phys_addr_lpae() not setting it to 1, because we pass that the same 'result' pointer, not a fresh one.
I clear it first: that patch is already merged: memset(result, 0, sizeof(*result)); ret = get_phys_addr_lpae(env, ipa, access_type, s2_mmu_idx, is_el0, result, fi); r~
[Prev in Thread] | Current Thread | [Next in Thread] |