[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 37/42] target/arm: Remove loop from get_phys_addr_lpae
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 37/42] target/arm: Remove loop from get_phys_addr_lpae |
Date: |
Fri, 7 Oct 2022 11:20:18 +0100 |
On Sat, 1 Oct 2022 at 18:02, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The unconditional loop was used both to iterate over levels
> and to control parsing of attributes. Use an explicit goto
> in both cases.
>
> While this appears less clean for iterating over levels, we
> will need to jump back into the middle of this loop for
> atomic updates, which is even uglier.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/ptw.c | 176 +++++++++++++++++++++++------------------------
> 1 file changed, 88 insertions(+), 88 deletions(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v3 32/42] target/arm: Extract HA and HD in aa64_va_parameters, (continued)
- [PATCH v3 33/42] target/arm: Split out S1TranslateResult type, Richard Henderson, 2022/10/01
- [PATCH v3 34/42] target/arm: Move be test for regime into S1TranslateResult, Richard Henderson, 2022/10/01
- [PATCH v3 35/42] target/arm: Move S1_ptw_translate outside arm_ld[lq]_ptw, Richard Henderson, 2022/10/01
- [PATCH v3 36/42] target/arm: Add ARMFault_UnsuppAtomicUpdate, Richard Henderson, 2022/10/01
- [PATCH v3 37/42] target/arm: Remove loop from get_phys_addr_lpae, Richard Henderson, 2022/10/01
- Re: [PATCH v3 37/42] target/arm: Remove loop from get_phys_addr_lpae,
Peter Maydell <=
- [PATCH v3 38/42] target/arm: Fix fault reporting in get_phys_addr_lpae, Richard Henderson, 2022/10/01
- [PATCH v3 39/42] target/arm: Don't shift attrs in get_phys_addr_lpae, Richard Henderson, 2022/10/01
- [PATCH v3 40/42] target/arm: Consider GP an attribute in get_phys_addr_lpae, Richard Henderson, 2022/10/01
- [PATCH v3 41/42] target/arm: Implement FEAT_HAFDBS, Richard Henderson, 2022/10/01