[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 1/6] qemu/bswap: Add const_le64()
From: |
Peter Maydell |
Subject: |
Re: [RFC PATCH 1/6] qemu/bswap: Add const_le64() |
Date: |
Tue, 11 Oct 2022 16:45:57 +0100 |
On Tue, 11 Oct 2022 at 16:22, Richard Henderson
<richard.henderson@linaro.org> wrote:
> On 10/11/22 02:48, Peter Maydell wrote:
> > This is kind of a weird API, because:
> > * it only exists for little-endian, not big-endian
> > * we use it in exactly two files (linux-user/elfload.c and
> > hw/input/virtio-input-hid.c)
> >
> > which leaves me wondering if there's a better way of doing
> > it that I'm missing. But maybe it's just that we never filled
> > out the missing bits of the API surface because we haven't
> > needed them yet. Richard ?
>
> It's piecemeal because, as you note, very few places require a version of
> byte swapping
> that must be applicable to static data. I certainly don't want to completely
> fill this
> out and have most of it remain unused.
Makes sense. In that case, other than ordering the definitions
64-32-16,
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
[RFC PATCH 2/6] qemu/uuid: Add UUID static initializer, ira . weiny, 2022/10/10
[RFC PATCH 6/6] hw/cxl/mailbox: Wire up Get/Set Event Interrupt policy, ira . weiny, 2022/10/10
[RFC PATCH 5/6] hw/cxl/cxl-events: Add event interrupt support, ira . weiny, 2022/10/10
[RFC PATCH 3/6] hw/cxl/cxl-events: Add CXL mock events, ira . weiny, 2022/10/10