[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 4/4] docs/devel: try and improve the language around patch re
From: |
Alex Bennée |
Subject: |
[RFC PATCH 4/4] docs/devel: try and improve the language around patch review |
Date: |
Wed, 12 Oct 2022 13:11:52 +0100 |
It is important that contributors take the review process seriously
and we collaborate in a respectful way while avoiding personal
attacks. Try and make this clear in the language.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
docs/devel/submitting-a-patch.rst | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/docs/devel/submitting-a-patch.rst
b/docs/devel/submitting-a-patch.rst
index 41771501bf..5b6dc7ddf1 100644
--- a/docs/devel/submitting-a-patch.rst
+++ b/docs/devel/submitting-a-patch.rst
@@ -434,14 +434,20 @@ developers will identify bugs, or suggest a cleaner
approach, or even
just point out code style issues or commit message typos. You'll need to
respond to these, and then send a second version of your patches with
the issues fixed. This takes a little time and effort on your part, but
-if you don't do it then your changes will never get into QEMU. It's also
-just polite -- it is quite disheartening for a developer to spend time
-reviewing your code and suggesting improvements, only to find that
-you're not going to do anything further and it was all wasted effort.
+if you don't do it then your changes will never get into QEMU.
+
+Remember that a maintainer is under no obligation to take your
+patches. If someone has spent the time reviewing your code and
+suggesting improvements and you simply re-post without either
+addressing the comment directly or providing additional justification
+for the change then it becomes wasted effort. You cannot demand others
+merge and then fix up your code after the fact.
When replying to comments on your patches **reply to all and not just
the sender** -- keeping discussion on the mailing list means everybody
-can follow it.
+can follow it. Remember the spirit of the :ref:`code_of_conduct` and
+keep discussions respectful and collaborative and avoid making
+personal comments.
.. _pay_attention_to_review_comments:
--
2.34.1
- Re: [RFC PATCH 1/4] docs/devel: add a maintainers section to development process, (continued)
[RFC PATCH 3/4] docs/devel: simplify the minimal checklist, Alex Bennée, 2022/10/12
[RFC PATCH 4/4] docs/devel: try and improve the language around patch review,
Alex Bennée <=
Re: [RFC PATCH 0/4] docs/devel suggestions for discussion, Stefan Hajnoczi, 2022/10/12
Re: [RFC PATCH 0/4] docs/devel suggestions for discussion, Paolo Bonzini, 2022/10/12
Re: [RFC PATCH 0/4] docs/devel suggestions for discussion, Mark Cave-Ayland, 2022/10/14