|
From: | Juan Quintela |
Subject: | Re: [PATCH v2] migration/channel-block: fix return value for qio_channel_block_{readv,writev} |
Date: | Fri, 14 Oct 2022 13:49:58 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Fiona Ebner <f.ebner@proxmox.com> wrote: > in the error case. The documentation in include/io/channel.h states > that -1 or QIO_CHANNEL_ERR_BLOCK should be returned upon error. Simply > passing along the return value from the bdrv-functions has the > potential to confuse the call sides. Non-blocking mode is not > implemented currently, so -1 it is. > > Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Queued in migration tree.
[Prev in Thread] | Current Thread | [Next in Thread] |