qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/28] qapi char: Elide redundant has_FOO in generated C


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 09/28] qapi char: Elide redundant has_FOO in generated C
Date: Tue, 18 Oct 2022 14:14:06 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1

On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with.  Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step.  This is the step for qapi/char.json.

Said commit explains the transformation in more detail.  The invariant
violations mentioned there do not occur here.

Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
  chardev/char-file.c    |  4 ++--
  chardev/char-socket.c  | 10 ++++------
  chardev/char-udp.c     |  1 -
  chardev/char.c         |  6 +-----
  tests/unit/test-char.c |  1 -
  scripts/qapi/schema.py |  1 -
  6 files changed, 7 insertions(+), 16 deletions(-)

Eventually s/char/chardev/ in subject.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]