On Fri, Oct 21, 2022 at 12:43 AM Michael S. Tsirkin <
mst@redhat.com> wrote:
On Thu, Oct 20, 2022 at 06:20:20PM +0530, Ani Sinha wrote:
> On Thu, Oct 20, 2022 at 6:15 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Thu, Oct 20, 2022 at 06:12:10PM +0530, Ani Sinha wrote:
> > > On Thu, Oct 20, 2022 at 6:08 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > > >
> > > > On Thu, Oct 20, 2022 at 06:04:56PM +0530, Ani Sinha wrote:
> > > > >
> > > > >
> > > > > Changelog:
> > > > > v6:
> > > > > - skip test when dependencies (xorriso for example) are not installed.
> > > > > - skip test when run on a platform other than x86_64.
> > > >
> > > > Hmm why is that btw?
> > >
> > > The bits binaries that generate the iso (grub-mkrescue etc) are built
> > > for and are known to work only on x86_64 platform. They might also
> > > work on amd64 but I do not have one at my disposal at the moment to
> > > check.
> > > On other platforms, for example 32 bit x86 and non-x86, those binaries
> > > will likely not work. The test will fail.
> >
> > confused. I thought we are distributing the iso?
>
> No, the test builds the iso after adding the modified test scripts and
> then spawns the vm with it. It is all part of the test itself.
> We need to do that so that the iso contains the newly added tests etc.
It's good to have for people developing tests, but for most qemu
developers please just have a ready iso and have avocado fetch it.
It's important to make tests run on all platforms.
This changes things a lot and goes down the path of where do we check in test code changes? Do we deal with multiple repos? Where do we keep iso? Etc. having a static iso limits us also.
If we can think through and come up with a consensus, I can write a second test. Else let's just go with this first. If we are really keen on running tests on multiple platforms, we can have binaries built for those.
We can think about moving iso generation into a VM too
but as a first step I guess we can live with a container.
--
MST