[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state |
Date: |
Mon, 24 Oct 2022 13:00:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> Cc: Stefano Brivio
>
> Laurent Vivier <lvivier@redhat.com> writes:
>
>> On 10/21/22 07:48, Markus Armbruster wrote:
>>> Laurent Vivier <lvivier@redhat.com> writes:
>>>
>>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
>>>
>>> Use cases?
>>
>> This is asked by Stefano Brivio to allow libvirt to detect if connection to
>> passt is lost and to restart passt.
[...]
>>> Could similar event signalling be useful for other kinds of netdev
>>> backends?
>>
>> I was wondering, but it becomes more complicated to be generic.
>
> Making something complicated and generic where a simpler special
> solution would do is the worst.
>
> Not quite as bad (but still plenty bad) is making a few special
> solutions first, then replace them all with a generic solution.
>
> I believe we should have a good, hard think on possible applications of
> a generic solution now.
>
> There is no need to hold back this series for that.
>
> If we conclude a generic solution is called for, we better replace this
> special solution before it becomes ABI. Either by replacing it before
> we release it, or by keeping it unstable until we replace it.
Stefano, any thoughts on this?
- [PATCH v13 09/17] net: stream: add unix socket, (continued)
- [PATCH v13 09/17] net: stream: add unix socket, Laurent Vivier, 2022/10/20
- [PATCH v13 11/17] net: dgram: move mcast specific code from net_socket_fd_init_dgram(), Laurent Vivier, 2022/10/20
- [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Laurent Vivier, 2022/10/20
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state,
Markus Armbruster <=
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Stefano Brivio, 2022/10/24
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Markus Armbruster, 2022/10/24
[PATCH v13 07/17] net: socket: Don't ignore EINVAL on netdev socket connection, Laurent Vivier, 2022/10/20
[PATCH v13 05/17] net: introduce qemu_set_info_str() function, Laurent Vivier, 2022/10/20
[PATCH v13 13/17] qemu-sockets: move and rename SocketAddress_to_str(), Laurent Vivier, 2022/10/20
[PATCH v13 12/17] net: dgram: add unix socket, Laurent Vivier, 2022/10/20
[PATCH v13 15/17] net: stream: move to QIO to enable additional parameters, Laurent Vivier, 2022/10/20
[PATCH v13 16/17] tests/qtest: netdev: test stream and dgram backends, Laurent Vivier, 2022/10/20
[PATCH v13 10/17] net: dgram: make dgram_dst generic, Laurent Vivier, 2022/10/20
[PATCH v13 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent, Laurent Vivier, 2022/10/20