Re: [PATCH] hw/hyperv/hyperv.c: Use device_cold_reset() instead of device_legacy_reset()

[Peter Maydell]

On Mon, 17 Oct 2022 at 15:03, Maciej S. Szmigiero
<mail@maciej.szmigiero.name> wrote:
>
> On 13.10.2022 21:39, Maciej S. Szmigiero wrote:
> > On 13.10.2022 19:18, Peter Maydell wrote:
> >> The semantic difference between the deprecated device_legacy_reset()
> >> function and the newer device_cold_reset() function is that the new
> >> function resets both the device itself and any qbuses it owns,
> >> whereas the legacy function resets just the device itself and nothing
> >> else.  In hyperv_synic_reset() we reset a SynICState, which has no
> >> qbuses, so for this purpose the two functions behave identically and
> >> we can stop using the deprecated one.
> >>
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >> ---
> >> NB: tested only with 'make check' and 'make check-avocado', which
> >> may well not exercise this.
> >>
> >
> > In general the patch LGTM, but I will runtime-test it on Monday
> > just to be sure.
> >
>
> Tested and works fine on QEMU with SynIC reset fix [1] applied, so:
> Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>

Thanks for testing; I'll take this through target-arm.next since
I'm doing a pullreq anyway, unless somebody would prefer otherwise.

-- PMM