Re: [PATCH v3 26/26] tests/tcg: include CONFIG_PLUGIN in config-host.mak

[Thomas Huth]

On 20/10/2022 13.52, Alex Bennée wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20221013131304.623740-1-pbonzini@redhat.com>
> ---
>   configure | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index 8c2c4c1a04..4275f5419f 100755
> --- a/configure
> +++ b/configure
> @@ -2486,6 +2486,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
>   if test -n "$gdb_bin"; then
>       echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
>   fi
> +if test "$plugins" = "yes" ; then
> +    echo "CONFIG_PLUGIN=y" >> $config_host_mak
> +fi

Ugh, this is super-confusing that the configuration for 
tests/tcg/config-host.mak uses the same variable as the configuration for 
the top level config-host.mak ... not the fault of this patch, but we should 
maybe disentangle this in the future and rename the variable to 
tcg_config_host_mak or something like that.

Anyway, for this patch:

Reviewed-by: Thomas Huth <thuth@redhat.com>