qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 28/30] contrib/plugins: protect execlog's last_exec expans


From: Richard Henderson
Subject: Re: [PATCH v4 28/30] contrib/plugins: protect execlog's last_exec expansion
Date: Fri, 28 Oct 2022 07:21:25 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 10/28/22 04:36, Alex Bennée wrote:
We originally naively treated expansion as safe because we expected
each new CPU/thread to appear in order. However the -M raspi2 model
triggered a case where a new high cpu_index thread started executing
just before a smaller one.

Clean this up by converting the GArray into the simpler GPtrArray and
then holding a lock for the expansion.

Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
Cc: Alexandre Iooss<erdnaxe@crans.org>
---
  contrib/plugins/execlog.c | 38 ++++++++++++++++++++++++++++++--------
  1 file changed, 30 insertions(+), 8 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]