Re: [PATCH 2/7] target/arm: Allow relevant HCR bits to be written for FEAT_EVT

[Richard Henderson]

On 10/29/22 00:39, Peter Maydell wrote:
> +    if (cpu_isar_feature(any_half_evt, cpu)) {
> +        valid_mask |= HCR_TICAB | HCR_TOCU | HCR_TID4;
> +    }
> +    if (cpu_isar_feature(any_evt, cpu)) {
> +        valid_mask |= HCR_TTLBIS | HCR_TTLBOS | HCR_TICAB | HCR_TOCU | 
> HCR_TID4;
> +    }

You don't need to set bits twice.  Either

  if (any_evt) {
  } else if (any_half_evt) {
  }

or remove the half bits from the second if.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~