Re: [PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py

[Paolo Bonzini]

I think sudo  needs to be changed to "sudo -n" in docker.py. Thanks for the report!

Paolo 

Il sab 29 ott 2022, 23:13 Stefan Weil <sw@weilnetz.de> ha scritto:

Am 29.10.22 um 21:46 schrieb Paolo Bonzini:

Il sab 29 ott 2022, 11:38 Stefan Weil <sw@weilnetz.de> ha scritto:

Am 15.09.22 um 10:41 schrieb Richard Henderson:
> On 9/14/22 16:59, Alex Bennée wrote:
>> We want to migrate from docker.py to building our images directly with
>> docker/podman. Before we get there we need to make sure we don't
>> re-introduce our layered builds so bug out if we see FROM qemu/ in a
>> Dockerfile.
>>
>> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
>> Acked-by: Thomas Huth<thuth@redhat.com>
>> Message-Id:<20220826172128.353798-24-alex.bennee@linaro.org>
>> ---
>>   tests/docker/docker.py | 38 ++++++++++----------------------------
>>   1 file changed, 10 insertions(+), 28 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> r~
>

I am not sure whether that is related, but with latest QEMU code I now
get an e-mail "SECURITY information [...]" each time when I run the
configure script (or just `tests/docker/docker.py probe`):

qemu.weilnetz.de : Oct 29 09:32:32 : stefan : a password is required ;
TTY=pts/0 ; PWD=/home/stefan/qemu/bin/ndebug/i686-w64-mingw32 ;
USER=root ; COMMAND=docker version

There is no docker installation on my Debian GNU Linux build machine.

It's not related, configure is checking whether "sudo docker" works.

You are right. "git bisect" finds that the security e-mails occur since another commit.

Stefan

c4575b59155e2e0065c29d56496dbf3e6ffd035b is the first bad commit
commit c4575b59155e2e0065c29d56496dbf3e6ffd035b
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu Sep 29 12:41:58 2022 +0100

    configure: store container engine in config-host.mak
    
    In preparation for removing $(DOCKER_SCRIPT) from the tests/tcg configuration
    files, have Make use the same container engine that had been probed at
    configure time.
    
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
    Message-Id: <20220929114231.583801-19-alex.bennee@linaro.org>

 configure                     | 11 ++++++++---
 tests/docker/Makefile.include |  2 +-
 2 files changed, 9 insertions(+), 4 deletions(-)