Re: [PATCH 1/3] tcg/sparc: Remove support for sparc32plus

[Philippe Mathieu-Daudé]

On 30/10/22 16:45, Peter Maydell wrote:
> On Mon, 17 Oct 2022 at 07:44, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > Since 9b9c37c36439, we have only supported sparc64 cpus.
> > Debian and Gentoo now only support 64-bit sparc64 userland,
> > so it is time to drop the 32-bit sparc64 userland: sparc32plus.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   tcg/sparc/tcg-target.h     |  11 ---
> >   tcg/tcg.c                  |  75 +----------------
> >   tcg/sparc/tcg-target.c.inc | 166 +++++++------------------------------
> >   3 files changed, 33 insertions(+), 219 deletions(-)
> >
> > diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h
> > index c050763049..8655acdbe5 100644
> > --- a/tcg/sparc/tcg-target.h
> > +++ b/tcg/sparc/tcg-target.h
> > @@ -25,8 +25,6 @@
> >   #ifndef SPARC_TCG_TARGET_H
> >   #define SPARC_TCG_TARGET_H
> >
> > -#define TCG_TARGET_REG_BITS 64
>
> Why do we delete this?

We get the default definition from include/tcg/tcg.h:

  58 /* Default target word size to pointer size.  */
  59 #ifndef TCG_TARGET_REG_BITS
  60 # if UINTPTR_MAX == UINT32_MAX
  61 #  define TCG_TARGET_REG_BITS 32
  62 # elif UINTPTR_MAX == UINT64_MAX
  63 #  define TCG_TARGET_REG_BITS 64