[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/8] hw/cxl/events: Add event status register
From: |
Jonathan Cameron |
Subject: |
Re: [PATCH v2 4/8] hw/cxl/events: Add event status register |
Date: |
Tue, 3 Jan 2023 16:36:59 +0000 |
On Wed, 21 Dec 2022 20:24:34 -0800
Ira Weiny <ira.weiny@intel.com> wrote:
> The device status register block was defined. However, there were no
> individual registers nor any data wired up.
>
> Define the event status register [CXL 3.0; 8.2.8.3.1] as part of the
> device status register block. Wire up the register and initialize the
> event status for each log.
>
> To support CXL 3.0 the version of the device status register block needs
> to be 2. Change the macro to allow for setting the version.
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>
Superficial comment from rebasing (I'll review once I have it all in place).
You haven't included cxl_events.h anywhere until the next patch.
As the enum is used in this patch we have a build problem.
I dragged the include in cxl_device.h forwards to this patch.
Jonathan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 4/8] hw/cxl/events: Add event status register,
Jonathan Cameron <=