Re: [PATCH v4] tests/qtest: netdev: test stream and dgram backends

[Laurent Vivier]

On 1/4/23 19:37, Thomas Huth wrote:
> On 03/01/2023 12.00, Laurent Vivier wrote:
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Notes:
> >      v4:
> >        - rework EXPECT_STATE()
> >        - use g_dir_make_tmp()
> >      v3:
> >      - Add "-M none" to avoid error:
> >        "No machine specified, and there is no default"
> >      v2:
> >      - Fix ipv6 free port allocation
> >      - Check for IPv4, IPv6, AF_UNIX
> >      - Use g_mkdtemp() rather than g_file_open_tmp()
> >      - Use socketpair() in test_stream_fd()
> >      v1: compared to v14 of "qapi: net: add unix socket type support to netdev 
> > backend":
> >      - use IP addresses 127.0.0.1 and ::1 rather than localhost
> >
> >   tests/qtest/meson.build     |   2 +
> >   tests/qtest/netdev-socket.c | 434 ++++++++++++++++++++++++++++++++++++
> >   2 files changed, 436 insertions(+)
> >   create mode 100644 tests/qtest/netdev-socket.c
>
> FYI, the test also does not work on FreeBSD. It hangs on both, FreeBSD 12 and 
> 13:
>
>   https://cirrus-ci.com/task/5024964768694272?logs=build#L6937
>
>   https://cirrus-ci.com/task/5379344567107584?logs=build#L6938

Thanks.

Are you sure it's this test?

The "/netdev/stream/inet/ipv6" seems to be the last one of the series (if I compare with 
previous machines) and it is OK in the logs.

I don't understand where it can hang as we have an internal 5 seconds timeout (in 
EXPECT_STATE()).

And I don't understand why we have only /netdev/stream tests and no 
/netdev/dgram tests.

Is it possible to have more details?

Laurent