[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] target/arm: fix handling of HLT semihosting in system mo
|
From: |
Peter Maydell |
|
Subject: |
Re: [RFC PATCH] target/arm: fix handling of HLT semihosting in system mode |
|
Date: |
Thu, 5 Jan 2023 11:51:41 +0000 |
On Thu, 5 Jan 2023 at 11:43, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The check semihosting_enabled() wants to know if the guest is
> currently in user mode. Unlike the other cases the test was inverted
> causing us to block semihosting calls in non-EL0 modes.
>
> Fixes: 19b26317e9 (target/arm: Honour -semihosting-config userspace=on)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Whoops. I guess I must have only tested SVC AA32 semihosting
or something. We should
Cc: qemu-stable@nongnu.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
and applied to target-arm.next.
-- PMM