Re: [PATCH] hw/net: Fix read of uninitialized memory in imx_fec.

[Peter Maydell]

On Thu, 5 Jan 2023 at 16:46, Cédric Le Goater <clg@kaod.org> wrote:
>
> On 1/5/23 16:33, Peter Maydell wrote:
> > On Wed, 21 Dec 2022 at 18:32, Stephen Longfield <slongfield@google.com> 
> > wrote:
> >>
> >> Size is used at lines 1088/1188 for the loop, which reads the last 4
> >> bytes from the crc_ptr so it does need to get increased, however it
> >> shouldn't be increased before the buffer is passed to CRC computation,
> >> or the crc32 function will access uninitialized memory.
> >>
> >> This was pointed out to me by clg@kaod.org during the code review of
> >> a similar patch to hw/net/ftgmac100.c
> >>
> >> Change-Id: Ib0464303b191af1e28abeb2f5105eb25aadb5e9b
> >> Signed-off-by: Stephen Longfield <slongfield@google.com>
> >> Reviewed-by: Patrick Venture <venture@google.com>
> >
> > Applied to target-arm.next, thanks.
>
> Did you take the ftgmac100 also ?

No, I missed that one (patches arriving over a holiday
period are more likely to get lost). ftgmac100 is aspeed,
can you remind me, are you handling those patches at the moment
or would you rather I took it through target-arm.next ?

thanks
-- PMM