Re: [PATCH 2/5] s390x/pv: Implement CGS check handler

[Cédric Le Goater]

[ .. ]

> > The problem is that QEMU doesn't know about the S390_FEAT_EXTENDED_LENGTH_SCCB
> > feature when the PV object link is first checked. So #248 CPUs is considered
> > valid, but when DIAG308_PV_START is called, it fails.
>
> Drat. Is there any chance that the check could be done somewhere later?
 
s390_pv_init() could be the place. It looks like a good option since the CPUs have
been initialized. To be explored.

Thanks,

C.


> > Let's simplify and use :
> >
> >      int offset_cpu = offsetof(ReadInfo, entries);
> >      pv_max_cpus = (TARGET_PAGE_SIZE - offset_cpu) /sizeof(CPUEntry);
> >
> > ?
>
> Depends ... if it is possible to use 248 CPUs with -cpu els=off,diag318=off 
> then it would be nicer to allow that, too?
>
>   Thomas