Re: [PATCH v5 1/2] tpm: convert tpmdev options processing to new visitor format

[James Bottomley]

On Thu, 2023-01-05 at 09:59 -0500, Stefan Berger wrote:
[...]
> > @@ -2658,7 +2646,6 @@ void qemu_init(int argc, char **argv)
> >       qemu_add_opts(&qemu_boot_opts);
> >       qemu_add_opts(&qemu_add_fd_opts);
> >       qemu_add_opts(&qemu_object_opts);
> > -    qemu_add_opts(&qemu_tpmdev_opts);
> >       qemu_add_opts(&qemu_overcommit_opts);
> >       qemu_add_opts(&qemu_msg_opts);
> >       qemu_add_opts(&qemu_name_opts);
> > @@ -2906,9 +2893,7 @@ void qemu_init(int argc, char **argv)
> >                   break;
> >   #ifdef CONFIG_TPM
> >               case QEMU_OPTION_tpmdev:
> > -                if (tpm_config_parse(qemu_find_opts("tpmdev"),
> > optarg) < 0) {
> > -                    exit(1);
> > -                }
> > +                tpm_config_parse(optarg);
> 
> The comment to v4 still applies:
> 
> $ qemu-system-x86_64 --tpmdev help
> Supported TPM types (choose only one):
>   passthrough   Passthrough TPM backend driver
>      emulator   TPM emulator backend driver
>         mssim   TPM mssim emulator backend driver
> VNC server running on ::1:5900

So I think if I parse this correctly, your complaint is the help option
no longer exit(1)'s?  It shouldn't do that because it's not a failure,
but I can code it to exit(0).

James