Re: [RFC PATCH 00/40] Toward class init of cpu features

[Richard Henderson]

On 1/7/23 02:19, Alex Bennée wrote:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > On 1/6/23 15:43, Alex Bennée wrote:
> > > What about cloning objects after they are realised? After all that is
> > > what we do for the core CPUClass in user-mode.
> >
> > No we don't.  Where do you get that idea?
>
> Well linux-user does cpu_copy which involves a create step followed by a
> reset and then a bunch of copying state across. Can we assume all CPUs
> get reset before they are actively used?

The hash table creation happens during qdev_realize, there in cpu_create.

> Would it be too hacky to defer the creation of those hash tables to the
> reset phase and skip it if already defined?

Even then you have the copy after the reset, so no, that won't work.


r~