qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] accel/tcg: Split out cpu_exec_{setjmp,loop}


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] accel/tcg: Split out cpu_exec_{setjmp,loop}
Date: Sat, 7 Jan 2023 21:13:00 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 7/1/23 19:20, Richard Henderson wrote:
Recently the g_assert(cpu == current_cpu) test has been
intermittently failing with gcc.  Reorg the code around
the setjmp to minimize the lifetime of the cpu variable
affected by the setjmp.

This appears to fix the existing issue with clang as well.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1147
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  accel/tcg/cpu-exec.c | 111 +++++++++++++++++++++----------------------
  1 file changed, 54 insertions(+), 57 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]