Re: [PATCH v2 1/1] tcg: add perfmap and jitdump

[Richard Henderson]

On 11/14/22 08:13, Ilya Leoshkevich wrote:
> -const void *tcg_splitwx_to_rx(void *rw);
> +const void *tcg_splitwx_to_rx(const void *rw);
>   void *tcg_splitwx_to_rw(const void *rx);
>   #else
> -static inline const void *tcg_splitwx_to_rx(void *rw)
> +static inline const void *tcg_splitwx_to_rx(const void *rw)

This is incorrect, or at least not as designed.

The idea is that any rw pointer is not const, and any rx pointer is const, and this 
declaration prevents double-conversion.


r~