[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/18] ui: Fix silent truncation of numeric keys in HMP se
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v3 02/18] ui: Fix silent truncation of numeric keys in HMP sendkey |
|
Date: |
Mon, 09 Jan 2023 12:50:59 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> * Markus Armbruster (armbru@redhat.com) wrote:
>> Keys are int. HMP sendkey assigns them from the value strtoul(),
>> silently truncating values greater than INT_MAX. Fix to reject them.
>>
>> While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl
>> won't complain.
>
> Last time through you said you could switch to qemu_strtoui, but
Did I? Oh, I did in review of
[PATCH 08/12] pci: Fix silent truncation of pcie_aer_inject_error argument
but failed to do it here, too.
> I just noticed we've actually got a qemu_strto*i* - that
> would remove the value comparison
Thanks!