[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/14] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP2_GPIO type
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 05/14] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP2_GPIO type name |
Date: |
Mon, 9 Jan 2023 15:02:57 +0100 |
Following docs/devel/style.rst guidelines, rename omap2_gpif_s ->
Omap2GpioState. This also remove a use of 'struct' in the
DECLARE_INSTANCE_CHECKER() macro call.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/gpio/omap_gpio.c | 20 ++++++++++----------
include/hw/arm/omap.h | 9 ++++-----
2 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c
index 23502315ea..a3341d70f1 100644
--- a/hw/gpio/omap_gpio.c
+++ b/hw/gpio/omap_gpio.c
@@ -210,7 +210,7 @@ struct omap2_gpio_s {
uint8_t delay;
};
-struct omap2_gpif_s {
+struct Omap2GpioState {
SysBusDevice parent_obj;
MemoryRegion iomem;
@@ -274,7 +274,7 @@ static inline void omap2_gpio_module_int(struct
omap2_gpio_s *s, int line)
static void omap2_gpio_set(void *opaque, int line, int level)
{
- struct omap2_gpif_s *p = opaque;
+ Omap2GpioState *p = opaque;
struct omap2_gpio_s *s = &p->modules[line >> 5];
line &= 31;
@@ -601,7 +601,7 @@ static void omap_gpif_reset(DeviceState *dev)
static void omap2_gpif_reset(DeviceState *dev)
{
- struct omap2_gpif_s *s = OMAP2_GPIO(dev);
+ Omap2GpioState *s = OMAP2_GPIO(dev);
int i;
for (i = 0; i < s->modulecount; i++) {
@@ -613,7 +613,7 @@ static void omap2_gpif_reset(DeviceState *dev)
static uint64_t omap2_gpif_top_read(void *opaque, hwaddr addr, unsigned size)
{
- struct omap2_gpif_s *s = opaque;
+ Omap2GpioState *s = opaque;
switch (addr) {
case 0x00: /* IPGENERICOCPSPL_REVISION */
@@ -642,7 +642,7 @@ static uint64_t omap2_gpif_top_read(void *opaque, hwaddr
addr, unsigned size)
static void omap2_gpif_top_write(void *opaque, hwaddr addr,
uint64_t value, unsigned size)
{
- struct omap2_gpif_s *s = opaque;
+ Omap2GpioState *s = opaque;
switch (addr) {
case 0x00: /* IPGENERICOCPSPL_REVISION */
@@ -699,7 +699,7 @@ static void omap_gpio_realize(DeviceState *dev, Error
**errp)
static void omap2_gpio_realize(DeviceState *dev, Error **errp)
{
- struct omap2_gpif_s *s = OMAP2_GPIO(dev);
+ Omap2GpioState *s = OMAP2_GPIO(dev);
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
int i;
@@ -771,19 +771,19 @@ static const TypeInfo omap_gpio_info = {
.class_init = omap_gpio_class_init,
};
-void omap2_gpio_set_iclk(omap2_gpif *gpio, omap_clk clk)
+void omap2_gpio_set_iclk(Omap2GpioState *gpio, omap_clk clk)
{
gpio->iclk = clk;
}
-void omap2_gpio_set_fclk(omap2_gpif *gpio, uint8_t i, omap_clk clk)
+void omap2_gpio_set_fclk(Omap2GpioState *gpio, uint8_t i, omap_clk clk)
{
assert(i <= 5);
gpio->fclk[i] = clk;
}
static Property omap2_gpio_properties[] = {
- DEFINE_PROP_INT32("mpu_model", struct omap2_gpif_s, mpu_model, 0),
+ DEFINE_PROP_INT32("mpu_model", Omap2GpioState, mpu_model, 0),
DEFINE_PROP_END_OF_LIST(),
};
@@ -801,7 +801,7 @@ static void omap2_gpio_class_init(ObjectClass *klass, void
*data)
static const TypeInfo omap2_gpio_info = {
.name = TYPE_OMAP2_GPIO,
.parent = TYPE_SYS_BUS_DEVICE,
- .instance_size = sizeof(struct omap2_gpif_s),
+ .instance_size = sizeof(Omap2GpioState),
.class_init = omap2_gpio_class_init,
};
diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h
index 29d2ed7e3b..9e30ba7ba2 100644
--- a/include/hw/arm/omap.h
+++ b/include/hw/arm/omap.h
@@ -108,16 +108,15 @@ DECLARE_INSTANCE_CHECKER(Omap1GpioState, OMAP1_GPIO,
TYPE_OMAP1_GPIO)
#define TYPE_OMAP2_GPIO "omap2-gpio"
-DECLARE_INSTANCE_CHECKER(struct omap2_gpif_s, OMAP2_GPIO,
+typedef struct Omap2GpioState Omap2GpioState;
+DECLARE_INSTANCE_CHECKER(Omap2GpioState, OMAP2_GPIO,
TYPE_OMAP2_GPIO)
-typedef struct omap2_gpif_s omap2_gpif;
-
/* TODO: clock framework (see above) */
void omap_gpio_set_clk(Omap1GpioState *gpio, omap_clk clk);
-void omap2_gpio_set_iclk(omap2_gpif *gpio, omap_clk clk);
-void omap2_gpio_set_fclk(omap2_gpif *gpio, uint8_t i, omap_clk clk);
+void omap2_gpio_set_iclk(Omap2GpioState *gpio, omap_clk clk);
+void omap2_gpio_set_fclk(Omap2GpioState *gpio, uint8_t i, omap_clk clk);
/* OMAP2 l4 Interconnect */
struct omap_l4_s;
--
2.38.1
- [PATCH 00/14] hw/arm: QOM OBJECT_DECLARE_SIMPLE_TYPE cleanups, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 01/14] hw/arm/pxa: Avoid forward-declaring PXA2xxI2CState, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 02/14] hw/gpio/omap_gpio: Add local variable to avoid embedded cast, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 04/14] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP1_GPIO type name, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 03/14] hw/arm/omap: Drop useless casts from void * to pointer, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 05/14] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP2_GPIO type name,
Philippe Mathieu-Daudé <=
- [PATCH 06/14] hw/intc/omap_intc: Use CamelCase for TYPE_OMAP_INTC type name, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 07/14] hw/arm/stellaris: Drop useless casts from void * to pointer, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 08/14] hw/arm/stellaris: Use CamelCase for STELLARIS_ADC type name, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 09/14] hw/arm/bcm2836: Remove definitions generated by OBJECT_DECLARE_TYPE(), Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 10/14] hw/arm/npcm7xx: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE(), Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 12/14] hw/misc/sbsa_ec: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE(), Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 11/14] hw/misc/sbsa_ec: Rename TYPE_SBSA_EC -> TYPE_SBSA_SECURE_EC, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 13/14] hw/intc/xilinx_intc: Use 'XpsIntc' typedef instead of 'struct xlx_pic', Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 14/14] hw/timer/xilinx_timer: Use XpsTimerState instead of 'struct timerblock', Philippe Mathieu-Daudé, 2023/01/09