[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] migration: report multiFd related thread pid to libvirt
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 2/2] migration: report multiFd related thread pid to libvirt |
Date: |
Mon, 9 Jan 2023 14:44:32 +0000 |
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Mon, Jan 09, 2023 at 07:16:31PM +0800, Jiang Jiacheng via wrote:
> From: Zheng Chuan <zhengchuan@huawei.com>
>
> Report multiFd related thread pid to libvirt in order to
> pin multiFd thread to different cpu.
> ---
> migration/multifd.c | 4 ++++
> qapi/migration.json | 12 ++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/migration/multifd.c b/migration/multifd.c
> index 000ca4d4ec..f3f7e8ae31 100644
> --- a/migration/multifd.c
> +++ b/migration/multifd.c
> @@ -17,6 +17,7 @@
> #include "exec/ramblock.h"
> #include "qemu/error-report.h"
> #include "qapi/error.h"
> +#include "qapi/qapi-events-migration.h"
> #include "ram.h"
> #include "migration.h"
> #include "socket.h"
> @@ -650,6 +651,9 @@ static void *multifd_send_thread(void *opaque)
> int ret = 0;
> bool use_zero_copy_send = migrate_use_zero_copy_send();
>
> + /* report multifd thread pid to libvirt */
> + qapi_event_send_migration_multifd_pid(qemu_get_thread_id());
> +
> trace_multifd_send_thread_start(p->id);
> rcu_register_thread();
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index aafc940617..33fc319329 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1286,6 +1286,18 @@
> { 'event': 'MIGRATION_PASS',
> 'data': { 'pass': 'int' } }
>
> +##
> +# @MIGRATION_MULTIFD_PID:
> +#
> +# Emitted when multifd thread appear
> +#
> +# @pid: pid of multifd thread
> +#
> +# Since: 7.2
> +##
> +{ 'event': 'MIGRATION_MULTIFD_PID',
> + 'data': { 'pid': 'int' } }
Why do we need to have separate events instead of emitting MIGRATION_PID
multiple times, possibly with a 'type' field if clients genuinely need
to distinguish multifd threads.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|