[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 02/17] ui: Fix silent truncation of numeric keys in HMP sendke
From: |
Markus Armbruster |
Subject: |
[PATCH v4 02/17] ui: Fix silent truncation of numeric keys in HMP sendkey |
Date: |
Mon, 9 Jan 2023 20:03:06 +0100 |
Keys are int. HMP sendkey assigns them from the value strtoul(),
silently truncating values greater than INT_MAX. Fix to reject them.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
monitor/hmp-cmds.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index ed78a87ddd..9947ff0b45 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1549,8 +1549,12 @@ void hmp_sendkey(Monitor *mon, const QDict *qdict)
v = g_malloc0(sizeof(*v));
if (strstart(keys, "0x", NULL)) {
- char *endp;
- int value = strtoul(keys, &endp, 0);
+ const char *endp;
+ int value;
+
+ if (qemu_strtoi(keys, &endp, 0, &value) < 0) {
+ goto err_out;
+ }
assert(endp <= keys + keyname_len);
if (endp != keys + keyname_len) {
goto err_out;
--
2.39.0
- [PATCH v4 00/17] ui: Move and clean up monitor command code, Markus Armbruster, 2023/01/09
- [PATCH v4 14/17] ui: Reduce nesting in hmp_change_vnc() slightly, Markus Armbruster, 2023/01/09
- [PATCH v4 02/17] ui: Fix silent truncation of numeric keys in HMP sendkey,
Markus Armbruster <=
- [PATCH v4 05/17] ui/spice: Require spice-server >= 0.14.0, Markus Armbruster, 2023/01/09
- [PATCH v4 04/17] Revert "hmp: info spice: take out webdav", Markus Armbruster, 2023/01/09
- [PATCH v4 16/17] ui: Split hmp_mouse_set() and move the HMP part to ui/, Markus Armbruster, 2023/01/09
- [PATCH v4 06/17] ui/spice: QXLInterface method set_mm_time() is now dead, drop, Markus Armbruster, 2023/01/09
- [PATCH v4 08/17] ui: Clean up a few things checkpatch.pl would flag later on, Markus Armbruster, 2023/01/09
- [PATCH v4 11/17] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c, Markus Armbruster, 2023/01/09
- [PATCH v4 17/17] ui: Simplify control flow in qemu_mouse_set(), Markus Armbruster, 2023/01/09