qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 06/19] target/arm: Move define_debug_regs() to cpregs.


From: Richard Henderson
Subject: Re: [RFC PATCH v2 06/19] target/arm: Move define_debug_regs() to cpregs.c
Date: Mon, 9 Jan 2023 21:41:14 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 1/9/23 14:42, Fabiano Rosas wrote:
-    hw_breakpoint_update_all(cpu);
-    hw_watchpoint_update_all(cpu);
+    if (tcg_enabled()) {
+        hw_breakpoint_update_all(cpu);
+        hw_watchpoint_update_all(cpu);
+    }

This and the other tcg_enabled() addition don't belong with code movement.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]