[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] python/qemu/machine: fix potential hang in QMP accept
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [PATCH v2 0/3] python/qemu/machine: fix potential hang in QMP accept |
|
Date: |
Tue, 10 Jan 2023 11:05:02 +0400 |
Hi John
On Tue, Jan 10, 2023 at 1:06 AM John Snow <jsnow@redhat.com> wrote:
>
> On Mon, Jul 25, 2022 at 7:23 AM Marc-André Lureau
> <marcandre.lureau@gmail.com> wrote:
> >
> > Hi
> >
> > On Fri, Jul 1, 2022 at 2:51 AM John Snow <jsnow@redhat.com> wrote:
> >>
> >> On Thu, Jun 30, 2022 at 8:34 AM <marcandre.lureau@redhat.com> wrote:
> >> >
> >> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >> >
> >> > Hi,
> >> >
> >> > As reported earlier by Richard Henderson ("virgl avocado hang" thread),
> >> > avocado
> >> > tests may hang when QEMU exits before the QMP connection is established.
> >> >
> >> > v2:
> >> > - use a socketpair() for QMP (instead of async concurrent code from v1)
> >> > as
> >> > suggested by Daniel Berrange.
> >> > - should not regress (hopefully)
> >> >
> >> > Marc-André Lureau (3):
> >> > python/qmp/protocol: add open_with_socket()
> >> > python/qmp/legacy: make QEMUMonitorProtocol accept a socket
> >> > python/qemu/machine: use socketpair() for QMP by default
> >> >
> >> > python/qemu/machine/machine.py | 24 ++++++++++++++++--------
> >> > python/qemu/qmp/legacy.py | 18 +++++++++++++++---
> >> > python/qemu/qmp/protocol.py | 25 ++++++++++++++++++++-----
> >> > 3 files changed, 51 insertions(+), 16 deletions(-)
> >> >
> >> > --
> >> > 2.37.0.rc0
> >> >
> >>
> >> For anything that touches python/qemu/qmp/*, may I please ask that you
> >> submit them to https://gitlab.com/qemu-project/python-qemu-qmp ?
> >>
> >
> > Ok
> >
> >>
> >> (I'll review them in the meantime on-list just in the interest of
> >> moving things along.)
> >
> >
> > I was waiting for a review before updating the patches / moving to
> > python-qemu-qmp.
> >
>
> Fair enough - can I kindly ask you to resend, though? My apologies and
> Happy New Year!
I am confused, what's the relation between QEMU python/qemu/qmp and
https://gitlab.com/qemu-project/python-qemu-qmp ?
When / how is the code sync ?
--
Marc-André Lureau