[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] cpu-exec: assert that plugin_mem_cbs is NULL after execu
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH 4/4] cpu-exec: assert that plugin_mem_cbs is NULL after execution |
|
Date: |
Tue, 10 Jan 2023 13:02:08 +0000 |
|
User-agent: |
mu4e 1.9.12; emacs 29.0.60 |
Emilio Cota <cota@braap.org> writes:
> On Mon, Jan 09, 2023 at 13:52:36 +0000, Alex Bennée wrote:
>> Emilio Cota <cota@braap.org> writes:
>> > --- a/accel/tcg/cpu-exec.c
>> > +++ b/accel/tcg/cpu-exec.c
>> > @@ -504,6 +504,7 @@ static void cpu_exec_exit(CPUState *cpu)
>> > if (cc->tcg_ops->cpu_exec_exit) {
>> > cc->tcg_ops->cpu_exec_exit(cpu);
>> > }
>> > + g_assert(cpu->plugin_mem_cbs == NULL);
> (snip)
>> > + g_assert(cpu->plugin_mem_cbs == NULL);
>>
>> Can we assert this anywhere else? This fails with non-plugin enabled
>> builds:
>>
>> https://gitlab.com/stsquad/qemu/-/pipelines/741478109/failures
>
> Ouch. Fixed in v2 with:
Thanks, Queued to plugins/next with me manually merging the fix.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro