Re: [PATCH 0/1] hw/ide: share bmdma read and write functions

[Bernhard Beschow]

Am 9. Januar 2023 19:24:16 UTC schrieb John Snow <jsnow@redhat.com>:
>On Tue, Sep 6, 2022 at 10:27 AM Bernhard Beschow <shentey@gmail.com> wrote:
>>
>> Am 19. Februar 2022 08:08:17 UTC schrieb Liav Albani <liavalb@gmail.com>:
>> >This is a preparation before I send v3 of ich6-ide controller emulation 
>> >patch.
>> >I figured that it's more trivial to split the changes this way, by 
>> >extracting
>> >the bmdma functions from via.c and piix.c and sharing them together. Then,
>> >I could easily put these into use when I send v3 of the ich6-ide patch by 
>> >just
>> >using the already separated functions. This was suggested by BALATON Zoltan 
>> >when
>> >he submitted a code review on my ich6-ide controller emulation patch.
>>
>> Ping. Any news?
>
>*cough*.
>
>Has this been folded into subsequent series, or does this still need attention?

Both piix and via still have their own bmdma implementations. This patch might 
be worth having.

Best regards,
Bernhard

>
>>
>> >Liav Albani (1):
>> >  hw/ide: share bmdma read and write functions between piix.c and via.c
>> >
>> > hw/ide/pci.c         | 47 ++++++++++++++++++++++++++++++++++++++++
>> > hw/ide/piix.c        | 50 ++-----------------------------------------
>> > hw/ide/via.c         | 51 ++------------------------------------------
>> > include/hw/ide/pci.h |  4 ++++
>> > 4 files changed, 55 insertions(+), 97 deletions(-)
>> >
>>
>