Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props()

From:	Richard Henderson
Subject:	Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props()
Date:	Tue, 10 Jan 2023 21:39:16 -0800
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 1/10/23 12:14, Daniel Henrique Barboza wrote:

+/*
+ * Register CPU props based on env.misa_ext. If a non-zero
+ * value was set, register only the required cpu->cfg.ext_*
+ * properties and leave. env.misa_ext = 0 means that we want
+ * all the default properties to be registered.
+ */
  static void register_cpu_props(DeviceState *dev)


Suggest invoking this as .instance_post_init hook on TYPE_RISCV_CPU.
Then you don't need to manually call it on every cpu class.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/2] target/riscv/cpu: fix sifive_u 32/64bits boot in riscv-to-apply.next, Daniel Henrique Barboza, 2023/01/10
- [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props(), Daniel Henrique Barboza, 2023/01/10
  - Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props(), Alistair Francis, 2023/01/10
  - Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props(), Richard Henderson <=
    - Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props(), Daniel Henrique Barboza, 2023/01/11
  - Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props(), Bin Meng, 2023/01/11
- [PATCH 2/2] target/riscv/cpu.c: do not skip misa logic in riscv_cpu_realize(), Daniel Henrique Barboza, 2023/01/10
  - Re: [PATCH 2/2] target/riscv/cpu.c: do not skip misa logic in riscv_cpu_realize(), Alistair Francis, 2023/01/10
  - Re: [PATCH 2/2] target/riscv/cpu.c: do not skip misa logic in riscv_cpu_realize(), Bin Meng, 2023/01/11
- Re: [PATCH 0/2] target/riscv/cpu: fix sifive_u 32/64bits boot in riscv-to-apply.next, Daniel Henrique Barboza, 2023/01/10
- Re: [PATCH 0/2] target/riscv/cpu: fix sifive_u 32/64bits boot in riscv-to-apply.next, Alistair Francis, 2023/01/11
  - Re: [PATCH 0/2] target/riscv/cpu: fix sifive_u 32/64bits boot in riscv-to-apply.next, Bin Meng, 2023/01/12
    - Re: [PATCH 0/2] target/riscv/cpu: fix sifive_u 32/64bits boot in riscv-to-apply.next, Daniel Henrique Barboza, 2023/01/13

Prev by Date: Re: [PATCH v5 00/11] riscv: OpenSBI boot test and cleanups
Next by Date: Re: [RFC PATCH v2 17/19] target/arm: Move regime_using_lpae_format into internal.h
Previous by thread: Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props()
Next by thread: Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props()
Index(es):
- Date
- Thread