Re: [PATCH 8/8] hw/cxl/mailbox: Use new UUID network order define for cel_uuid

[Philippe Mathieu-Daudé]

On 11/1/23 15:24, Jonathan Cameron via wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> The cel_uuid was programatically generated previously because there was
> no static initializer for network order UUIDs.
>
> Use the new network order initializer for cel_uuid.  Adjust
> cxl_initialize_mailbox() because it can't fail now.
>
> Update specification reference.
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>   hw/cxl/cxl-device-utils.c   |  2 +-
>   hw/cxl/cxl-mailbox-utils.c  | 13 ++++++-------
>   include/hw/cxl/cxl_device.h |  2 +-
>   3 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/hw/cxl/cxl-device-utils.c b/hw/cxl/cxl-device-utils.c
> index 83ce7a8270..4c5e88aaf5 100644
> --- a/hw/cxl/cxl-device-utils.c
> +++ b/hw/cxl/cxl-device-utils.c
> @@ -267,5 +267,5 @@ void cxl_device_register_init_common(CXLDeviceState 
> *cxl_dstate)
>       cxl_device_cap_init(cxl_dstate, MEMORY_DEVICE, 0x4000);
>       memdev_reg_init_common(cxl_dstate);
>   
> -    assert(cxl_initialize_mailbox(cxl_dstate) == 0);
> +    cxl_initialize_mailbox(cxl_dstate);
>   }
> diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
> index 942de73bbc..7ed344a754 100644
> --- a/hw/cxl/cxl-mailbox-utils.c
> +++ b/hw/cxl/cxl-mailbox-utils.c
> @@ -192,7 +192,11 @@ static ret_code cmd_timestamp_set(struct cxl_cmd *cmd,
>       return CXL_MBOX_SUCCESS;
>   }
>   
> -static QemuUUID cel_uuid;
> +/* CXL 3.0 8.2.9.5.2.1 Command Effects Log (CEL) */
> +static QemuUUID cel_uuid = {

static const.

Otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> +        .data = UUID(0x0da9c0b5, 0xbf41, 0x4b78, 0x8f, 0x79,
> +                     0x96, 0xb1, 0x62, 0x3b, 0x3f, 0x17)
> +};
>   
>   /* 8.2.9.4.1 */
>   static ret_code cmd_logs_get_supported(struct cxl_cmd *cmd,
> @@ -457,11 +461,8 @@ void cxl_process_mailbox(CXLDeviceState *cxl_dstate)
>                        DOORBELL, 0);
>   }