qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v3 23/28] tests/tcg: Do not build/run TCG tests if TCG is


From: Thomas Huth
Subject: Re: [RFC PATCH v3 23/28] tests/tcg: Do not build/run TCG tests if TCG is disabled
Date: Fri, 13 Jan 2023 15:27:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 13/01/2023 15.04, Fabiano Rosas wrote:
The tests under tests/tcg depend on the TCG accelerator. Do not build
them if --disable-tcg was given in the configure line.

Test against CONFIG_TCG='' instead of CONFIG_TCG=y to account for
CONFIG_TCG=m.

sample output:

$ make check-tcg
   GIT     ui/keycodemapdb meson dtc
   SKIPPED x86_64-softmmu guest-tests because TCG is disabled in this build

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
  configure              |  4 ++++
  tests/Makefile.include | 10 ++++++++++
  2 files changed, 14 insertions(+)

diff --git a/configure b/configure
index 9e407ce2e3..a6f9892757 100755
--- a/configure
+++ b/configure
@@ -2352,6 +2352,10 @@ if test "$plugins" = "yes" ; then
      echo "CONFIG_PLUGIN=y" >> $config_host_mak
  fi
+if test "$tcg" = "enabled" ; then
+    echo "CONFIG_TCG=y" >> $config_host_mak
+fi

Commit 8a19980e3fc42239a moved CONFIG_TCG to meson.build, so this looks backward now ... could you maybe simply make sure that TCG_TESTS_TARGETS does not get set in config-host.mak if TCG is disabled?

 Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]